Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gethostbyname expert: numeric value for parameter "gaierrors_to_ignore" crashes bot #2072

Closed
ghost opened this issue Aug 27, 2021 · 0 comments · Fixed by #2073
Closed

gethostbyname expert: numeric value for parameter "gaierrors_to_ignore" crashes bot #2072

ghost opened this issue Aug 27, 2021 · 0 comments · Fixed by #2073
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Milestone
3.0.1

Comments

@ghost
Copy link

ghost commented Aug 27, 2021

If the configuration for the gethostbyname expert contains

    gaierrors_to_ignore: -3

or if you enter a (single) numeric value in the manager, which automatically saves it as integer, not as string, the bot does not start with:

gethostbyname-1-expert: Bot initialization failed.
Traceback (most recent call last):
  File "/dev/intelmq/intelmq/lib/bot.py", line 209, in __init__
    self.init()
  File "/dev/intelmq/intelmq/bots/experts/gethostbyname/expert.py", line 43, in init
    ignore = ignore.split(',')
AttributeError: 'int' object has no attribute 'split'

A workaround is to encapsulate the value in quotes.
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: bots labels Aug 27, 2021
@ghost ghost added this to the 3.0.1 milestone Aug 27, 2021
@ghost ghost self-assigned this Aug 27, 2021
ghost pushed a commit that referenced this issue Aug 27, 2021
BUG: gethostbyname: handle numeric gaierrors_to_ignore
3373c45 
If the configuration for the gethostbyname expert contains

    gaierrors_to_ignore: -3

or if you enter a (single) numeric value in the manager, which automatically saves it as integer, not as string, the bot does not start with:

gethostbyname-1-expert: Bot initialization failed.
Traceback (most recent call last):
  File "/dev/intelmq/intelmq/lib/bot.py", line 209, in __init__
    self.init()
  File "/dev/intelmq/intelmq/bots/experts/gethostbyname/expert.py", line 43, in init
    ignore = ignore.split(',')
AttributeError: 'int' object has no attribute 'split'

A workaround is to encapsulate the value in quotes.

fixes #2072
@ghost ghost mentioned this issue Aug 27, 2021
Merged
@ghost ghost linked a pull request Aug 27, 2021 that will close this issue
BUG: gethostbyname: handle numeric gaierrors_to_ignore #2073
Merged
@ghost ghost closed this as completed in 81750ef Aug 30, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Projects
None yet
Milestone
3.0.1
Development

Successfully merging a pull request may close this issue.

BUG: gethostbyname: handle numeric gaierrors_to_ignore certtools/intelmq
0 participants