Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadowserver parser docs missing part on feedname #2455

Closed
gethvi opened this issue Feb 1, 2024 · 2 comments · Fixed by #2460
Closed

Shadowserver parser docs missing part on feedname #2455

gethvi opened this issue Feb 1, 2024 · 2 comments · Fixed by #2460
Labels
bug Indicates an unexpected problem or unintended behavior documentation Indicates a need for improvements or additions to documentation
Milestone

Comments

@gethvi
Copy link
Contributor

gethvi commented Feb 1, 2024

Shadowserver parser docs says:

A list of possible values of the feedname parameter can be found in the table below in the column "Report Type".

This is no longer true. I understand that the feedname mapping is now gathered from the schema, but still the user doesn't know what feedname he should use for configuration.

If we want to keep the possibility for "fixed report type" we should provide the user with easily accessible values he can use for feedname parameter.

@gethvi gethvi added bug Indicates an unexpected problem or unintended behavior documentation Indicates a need for improvements or additions to documentation labels Feb 1, 2024
@gethvi gethvi added this to the 3.2.2 milestone Feb 1, 2024
@sebix
Copy link
Member

sebix commented Feb 5, 2024

@elsif2

@elsif2
Copy link
Collaborator

elsif2 commented Feb 5, 2024

The feed_name for each report type is included in the schema:

   "population_msmq" : {
      "constant_fields" : {
         "classification.identifier" : "accessible-msmq",
         "classification.taxonomy" : "vulnerable",
         "classification.type" : "potentially-unwanted-accessible",
         "protocol.application" : "msmq"
      },
      "feed_name" : "Accessible-MSMQ",
      "file_name" : "population_msmq",

elsif2 added a commit that referenced this issue Feb 5, 2024
@elsif2 elsif2 linked a pull request Feb 5, 2024 that will close this issue
sebix added a commit that referenced this issue Feb 6, 2024
…-missing-part-on-feedname

Documentation update for #2455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior documentation Indicates a need for improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants