Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode or ASCII domains for FQDNs? #622

Closed
sebix opened this issue Jul 28, 2016 · 3 comments
Closed

Unicode or ASCII domains for FQDNs? #622

sebix opened this issue Jul 28, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@sebix
Copy link
Member

sebix commented Jul 28, 2016

Currently, both representations are valid. But we should convert them to only one representation, avoiding duplicates.

>>> harm.FQDN.is_valid('ö1.at')
True
>>> harm.FQDN.is_valid('xn--1-0ga.at')
True
@sebix sebix added this to the Release v1.0 milestone Jul 28, 2016
@aaronkaplan
Copy link
Member


Mobile

On 28.07.2016, at 15:00, Sebastian notifications@github.com wrote:

Currently, bot representations are valid. But we should convert them to only one representation, avoiding duplicates.

harm.FQDN.is_valid('ö1.at')
True
harm.FQDN.is_valid('xn--1-0ga.at')
True

You mean normalize ?
I am for the xn-- standard in this case.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@sebix sebix self-assigned this Jul 29, 2016
@sebix sebix added the feature request Indicates new feature requests label Jul 29, 2016
@aaronkaplan
Copy link
Member

okay, decision: normalisation is IDN ("xn--" format)

@SYNchroACK
Copy link
Contributor

@aaronkaplan +1 ;)

sebix added a commit that referenced this issue Nov 9, 2016
fixes #622

Signed-off-by: Sebastian Wagner <sebix@sebix.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants