Add new bot: cut string from string

[mariuskarotkis]

Add new bot: cut string from string

[ghost]

Please add documentation in docs/user/bots.rst

[codecov-commenter]

Codecov Report

Merging #1965 (a3f6d9b) into develop (0750a3d) will increase coverage by 0.31%.
The diff coverage is 91.66%.

❗ Current head a3f6d9b differs from pull request most recent head 4f804c7. Consider uploading reports for the commit 4f804c7 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1965      +/-   ##
===========================================
+ Coverage    75.74%   76.06%   +0.31%     
===========================================
  Files          414      434      +20     
  Lines        22169    23189    +1020     
  Branches      2944     3099     +155     
===========================================
+ Hits         16793    17639     +846     
- Misses        4697     4841     +144     
- Partials       679      709      +30     

Impacted Files	Coverage Δ
intelmq/bots/experts/cut_from_string/expert.py	82.60% <82.60%> (ø)
.../tests/bots/experts/cut_from_string/test_expert.py	100.00% <100.00%> (ø)
intelmq/tests/bots/experts/wait/test_expert.py	50.00% <0.00%> (-50.00%)	⬇️
intelmq/bots/experts/wait/expert.py	48.57% <0.00%> (-31.43%)	⬇️
intelmq/bots/parsers/cert_eu/parser_csv.py	78.84% <0.00%> (-2.79%)	⬇️
intelmq/bots/parsers/misp/parser.py	85.45% <0.00%> (-2.79%)	⬇️
intelmq/bots/experts/tor_nodes/expert.py	46.42% <0.00%> (-2.33%)	⬇️
intelmq/bots/collectors/mail/_lib.py	67.27% <0.00%> (-1.96%)	⬇️
intelmq/bots/experts/asn_lookup/expert.py	35.83% <0.00%> (-1.89%)	⬇️
...telmq/bots/experts/recordedfuture_iprisk/expert.py	41.93% <0.00%> (-1.89%)	⬇️
... and 421 more

[ghost]

If I understand correctly, the bot will remove a prefix or a suffix from a field. So I would call it RemoveAffix. There is also PEP616 which proposes str methods which do exactly that and which seems to have been accepted for Python 3.9. So once we only support Python 3.9, we can use that (maybe add a comment so that we don't forget).

Please add a reuse compliant license and copyright header to the files, an example can be found in the documentation

[mariuskarotkis]

Updated

[mariuskarotkis]

If I understand correctly, the bot will remove a prefix or a suffix from a field. So I would call it RemoveAffix. There is also PEP616 which proposes str methods which do exactly that and which seems to have been accepted for Python 3.9. So once we only support Python 3.9, we can use that (maybe add a comment so that we don't forget).

Please add a reuse compliant license and copyright header to the files, an example can be found in the documentation

Please check.

[ghost]

If I understand correctly, the bot will remove a prefix or a suffix from a field. So I would call it RemoveAffix. There is also PEP616 which proposes str methods which do exactly that and which seems to have been accepted for Python 3.9. So once we only support Python 3.9, we can use that (maybe add a comment so that we don't forget).
Please add a reuse compliant license and copyright header to the files, an example can be found in the documentation

Please check.

Thanks, it looks better now from my point of view. There are still a couple of tests that fail, please fix those (apparently the function parameter syntax / was only introduced in Python 3.8, given that we also support 3.6 we have to live without it)

outdated

[ghost]

I think the only discussion point left open is this comment/proposal by @schacht-certat:

If I understand correctly, the bot will remove a prefix or a suffix from a field. So I would call it RemoveAffix.

@mariuskarotkis What do you think of this idea? Does something indicate against it?

outdated

[mariuskarotkis]

RemoveAffix

It's good for me. I think it can be renamed.

[ghost]

Thank you very much - again! - for this useful addition.