Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTIP parser: Handle TLP value "unknown" #2009

Merged
2 commits merged into from
Jun 30, 2021
Merged

CTIP parser: Handle TLP value "unknown" #2009

2 commits merged into from
Jun 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2021

ENH: harm: simplify TLP sanitiation
the value is upper-case only already, so remove the case-insensitive code

BUG: ctip parser: handle TLP value 'unknown'
fixes #2008

Sebastian Wagner added 2 commits June 30, 2021 11:37
the value is upper-case only already, so remove the case-insensitive
code
@ghost ghost changed the title CTIP parser: Handle TLP value CTIP parser: Handle TLP value "unknown" Jun 30, 2021
@ghost ghost requested a review from waldbauer-certat June 30, 2021 09:43
@ghost ghost added this to the 3.0.0 milestone Jun 30, 2021
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: bots labels Jun 30, 2021
@ghost ghost self-assigned this Jun 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #2009 (18706cd) into develop (dc4060e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2009      +/-   ##
===========================================
- Coverage    75.95%   75.95%   -0.01%     
===========================================
  Files          423      423              
  Lines        22732    22734       +2     
  Branches      3019     3020       +1     
===========================================
+ Hits         17267    17268       +1     
  Misses        4758     4758              
- Partials       707      708       +1     
Impacted Files Coverage Δ
...s/bots/parsers/microsoft/test_parser_ctip_azure.py 100.00% <ø> (ø)
intelmq/bots/parsers/microsoft/parser_ctip.py 85.88% <100.00%> (+0.34%) ⬆️
intelmq/lib/harmonization.py 87.51% <100.00%> (ø)
intelmq/bots/experts/ripe/expert.py 76.53% <0.00%> (-1.03%) ⬇️
intelmq/lib/upgrades.py 69.01% <0.00%> (ø)

@ghost ghost merged commit 85ab0aa into develop Jun 30, 2021
@ghost ghost deleted the fix-2008 branch June 30, 2021 15:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft CTIP parser: TLP value "UNKNOWN" raises exception
2 participants