BUG: utils/load_configuration: fix loading JSON with tabs #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
bug
ghost
requested a review
from
ghost
self-assigned this
Codecov Report
@@ Coverage Diff @@
## develop #2010 +/- ##
===========================================
- Coverage 75.95% 75.95% -0.01%
===========================================
Files 423 423
Lines 22732 22751 +19
Branches 3019 3021 +2
===========================================
+ Hits 17267 17281 +14
- Misses 4758 4761 +3
- Partials 707 709 +2
|
ruamel can't load JSON files with tabs as whitespace if this specific excpetion is thrown, try loading the file with json.load instead this adds some tests for the load_configuration function with JSON files and YAML file fixes #1999
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruamel can't load JSON files with tabs as whitespace
if this specific excpetion is thrown, try loading the file with
json.load instead
this adds some tests for the load_configuration function
with JSON files and YAML file