Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: s/self.parameters/self/ in Shodan collector #2020

Merged
1 commit merged into from
Jul 27, 2021

Conversation

monoidic
Copy link
Contributor

The error_max_retries attribute is no longer accessed via self.parameters and the Shodan collector appears to have been missed in the updates.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #2020 (82ff6e4) into develop (b6f807e) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #2020   +/-   ##
========================================
  Coverage    75.99%   76.00%           
========================================
  Files          423      423           
  Lines        22778    22778           
  Branches      3022     3022           
========================================
+ Hits         17311    17312    +1     
  Misses        4758     4758           
+ Partials       709      708    -1     
Impacted Files Coverage Δ
intelmq/bots/collectors/shodan/collector_stream.py 39.02% <0.00%> (ø)
intelmq/bots/experts/ripe/expert.py 77.55% <0.00%> (+1.02%) ⬆️

@ghost ghost added this to the 3.0.1 milestone Jul 27, 2021
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: bots labels Jul 27, 2021
@ghost ghost self-assigned this Jul 27, 2021
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost ghost changed the base branch from develop to maintenance July 27, 2021 17:55
@ghost ghost changed the base branch from maintenance to develop July 27, 2021 17:56
@ghost ghost merged commit 98f83da into certtools:develop Jul 27, 2021
@ghost
Copy link

ghost commented Jul 27, 2021

Also cherry-picked for maintenance in 7f1eda7

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: bots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants