Make update script less verbose by default #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added this to the 
Codecov Report
@@ Coverage Diff @@
## develop #2033 +/- ##
===========================================
- Coverage 76.07% 76.00% -0.07%
===========================================
Files 425 425
Lines 22824 22845 +21
Branches 3023 3039 +16
===========================================
Hits 17364 17364
- Misses 4754 4775 +21
Partials 706 706
|
ghost
force-pushed
the
schacht/cron-output
branch
2 times, most recently
from
24017fb
to
0759362
Compare
ghost
marked this pull request as ready for review
ghost
self-requested a review
This introduces a --verbose flag to the experts which use update functions. The default behaviour now is to *not* print any messages, which makes the update function less noisy when used with cron. Fixes #2016
ghost
force-pushed
the
schacht/cron-output
branch
from
0759362
to
ead8ceb
Compare
ghost
approved these changes
Aug 11, 2021
|
Also cherry-picked for maintenance |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a --verbose flag to the experts which use update
functions. The default behaviour now is to not print any messages,
which makes the update function less noisy when used with cron.
Fixes #2016
In the long run we should probably move the update logic to the bot class itself.