Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the YAML unsafe loader instead of the safe loader #2041

Merged
1 commit merged into from
Aug 19, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 16, 2021

This lets us be backwards compatible to JSON and still dump YAML in a
readable format.

Another approach would be to first try to load JSON and only if that fails use yaml with the default loader.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #2041 (c3ccfcb) into develop (9d4baa8) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff            @@
##           develop    #2041   +/-   ##
========================================
  Coverage    75.98%   75.98%           
========================================
  Files          429      429           
  Lines        23011    23011           
  Branches      3062     3062           
========================================
  Hits         17486    17486           
  Misses        4817     4817           
  Partials       708      708           
Impacted Files Coverage Δ
intelmq/lib/pipeline.py 64.70% <50.00%> (ø)
intelmq/lib/utils.py 72.36% <100.00%> (ø)

This lets us be backwards compatible to JSON and still dump YAML in a
readable format.

Closes: #2003
@ghost ghost marked this pull request as ready for review August 16, 2021 08:11
@ghost
Copy link

ghost commented Aug 16, 2021

fixes #2003

@ghost ghost linked an issue Aug 16, 2021 that may be closed by this pull request
@ghost ghost added this to the 3.0.1 milestone Aug 16, 2021
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: core labels Aug 16, 2021
@ghost ghost merged commit 09e1d59 into develop Aug 19, 2021
@ghost ghost deleted the schacht/ruamel branch August 19, 2021 08:38
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: core
Development

Successfully merging this pull request may close these issues.

ruamel.yaml loader and dumper: human readability / support for comments
1 participant