Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Honeypot HTTP Scan feed to Shadowserver parser #2047

Merged
3 commits merged into from
Aug 23, 2021

Conversation

monoidic
Copy link
Contributor

This PR adds the Honeypot HTTP Scan feed to the Shadowserver parser, along with the related sample and test.

@monoidic monoidic force-pushed the shadowserver-event4_honeypot_http_scan branch 3 times, most recently from 680bbdb to 66cebe1 Compare August 17, 2021 13:50
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #2047 (b550d3b) into develop (9d4baa8) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2047      +/-   ##
===========================================
+ Coverage    75.98%   76.03%   +0.04%     
===========================================
  Files          429      429              
  Lines        23011    23036      +25     
  Branches      3062     3063       +1     
===========================================
+ Hits         17486    17516      +30     
+ Misses        4817     4814       -3     
+ Partials       708      706       -2     
Impacted Files Coverage Δ
intelmq/bots/parsers/shadowserver/_config.py 98.73% <100.00%> (+1.45%) ⬆️
...ers/shadowserver/test_event4_honeypot_http_scan.py 100.00% <100.00%> (ø)
...q/tests/bots/outputs/sql/test_output_postgresql.py 86.95% <0.00%> (-0.19%) ⬇️
intelmq/tests/bots/outputs/smtp/test_output.py 100.00% <0.00%> (ø)
intelmq/bots/outputs/postgresql/output.py
intelmq/lib/bot.py 62.48% <0.00%> (+0.42%) ⬆️
intelmq/bots/outputs/smtp/output.py 79.36% <0.00%> (+0.67%) ⬆️

@ghost ghost self-requested a review August 18, 2021 13:19
@ghost ghost added this to the 3.0.1 milestone Aug 18, 2021
@ghost ghost self-assigned this Aug 18, 2021
@ghost ghost added component: bots feature request Indicates new feature requests labels Aug 18, 2021
@monoidic monoidic force-pushed the shadowserver-event4_honeypot_http_scan branch 4 times, most recently from 9cb5937 to 7be66f1 Compare August 19, 2021 11:27
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise ready for merge (tests are appreciated but not required)

intelmq/bots/parsers/shadowserver/_config.py Outdated Show resolved Hide resolved
@monoidic
Copy link
Contributor Author

Ah, right. I'll add some tests on monday (friday's a national holiday).

@monoidic monoidic force-pushed the shadowserver-event4_honeypot_http_scan branch from d1bc46f to b550d3b Compare August 23, 2021 08:40
@monoidic
Copy link
Contributor Author

I added validate=True to the decode step, as by default, the base64 module just silently ignores invalid characters, which is the opposite of the intended effect, and some tests.

@ghost ghost merged commit 9f07fcb into certtools:develop Aug 23, 2021
@ghost
Copy link

ghost commented Aug 23, 2021

Thanks! also cherry-picked for maintenance (coming 3.0.1 release)

@ghost ghost mentioned this pull request Aug 23, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: bots feature request Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants