Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/harm: minor change to allowed classification.types list #2057

Merged
1 commit merged into from
Aug 23, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 20, 2021

change type from list to tuple, this list is immutable
sort
remove duplicate value system-compromise

change type from list to tuple, this list is immutable
sort
remove duplicate value system-compromise
@ghost ghost added the component: core label Aug 20, 2021
@ghost ghost added this to the 3.1.0 milestone Aug 20, 2021
@ghost ghost self-requested a review August 20, 2021 06:05
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #2057 (97e6664) into develop (e489bee) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2057      +/-   ##
===========================================
- Coverage    75.99%   75.98%   -0.01%     
===========================================
  Files          428      428              
  Lines        23002    23002              
  Branches      3061     3061              
===========================================
- Hits         17480    17479       -1     
  Misses        4815     4815              
- Partials       707      708       +1     
Impacted Files Coverage Δ
intelmq/lib/harmonization.py 87.21% <100.00%> (ø)
intelmq/bots/experts/ripe/expert.py 76.53% <0.00%> (-1.03%) ⬇️

@ghost ghost merged commit d379d12 into develop Aug 23, 2021
@ghost ghost deleted the wagner/minor-class-type branch August 23, 2021 12:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant