Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: make json output indented to make it better readable by humans #2079

Merged
1 commit merged into from
Aug 31, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 30, 2021

No description provided.

@ghost ghost added this to the 3.1.0 milestone Aug 31, 2021
@ghost ghost force-pushed the schacht/json-indent branch from dc7b188 to bef4578 Compare August 31, 2021 07:03
@codecov-commenter
Copy link

Codecov Report

Merging #2079 (dc7b188) into develop (ce7ebca) will decrease coverage by 0.00%.
The diff coverage is 22.11%.

❗ Current head dc7b188 differs from pull request most recent head bef4578. Consider uploading reports for the commit bef4578 to get more accurate results

@@             Coverage Diff             @@
##           develop    #2079      +/-   ##
===========================================
- Coverage    76.05%   76.04%   -0.01%     
===========================================
  Files          433      434       +1     
  Lines        23158    23218      +60     
  Branches      3095     3104       +9     
===========================================
+ Hits         17612    17657      +45     
- Misses        4839     4852      +13     
- Partials       707      709       +2     
Impacted Files Coverage Δ
intelmq/bin/intelmqctl.py 9.34% <9.74%> (-3.49%) ⬇️
intelmq/lib/processmanager.py 23.99% <23.99%> (ø)
intelmq/lib/datatypes.py 91.66% <93.33%> (+2.77%) ⬆️
intelmq/lib/bot.py 63.45% <0.00%> (-0.29%) ⬇️

@ghost ghost added the usability label Aug 31, 2021
@ghost ghost marked this pull request as ready for review August 31, 2021 07:40
@ghost ghost merged commit 51797d6 into develop Aug 31, 2021
@ghost ghost deleted the schacht/json-indent branch August 31, 2021 16:02
@ghost
Copy link

ghost commented Aug 31, 2021

I did a quick test in the manager if nothing breaks and it seems to work as expected.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant