Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: use correct private parameter variable #2087

Merged
1 commit merged into from
Aug 31, 2021
Merged

BUG: use correct private parameter variable #2087

1 commit merged into from
Aug 31, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 31, 2021

Closes: #2084

@ghost ghost marked this pull request as ready for review August 31, 2021 06:54
@ghost ghost self-requested a review August 31, 2021 06:54
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #2087 (fd4f88f) into develop (ce7ebca) will decrease coverage by 0.00%.
The diff coverage is 22.11%.

❗ Current head fd4f88f differs from pull request most recent head 68c4182. Consider uploading reports for the commit 68c4182 to get more accurate results

@@             Coverage Diff             @@
##           develop    #2087      +/-   ##
===========================================
- Coverage    76.05%   76.04%   -0.01%     
===========================================
  Files          433      434       +1     
  Lines        23158    23218      +60     
  Branches      3095     3104       +9     
===========================================
+ Hits         17612    17657      +45     
- Misses        4839     4852      +13     
- Partials       707      709       +2     
Impacted Files Coverage Δ
intelmq/bin/intelmqctl.py 9.34% <9.74%> (-3.49%) ⬇️
intelmq/lib/processmanager.py 23.99% <23.99%> (ø)
intelmq/lib/datatypes.py 91.66% <93.33%> (+2.77%) ⬆️
intelmq/lib/bot.py 63.45% <0.00%> (-0.29%) ⬇️

@ghost ghost added this to the 3.1.0 milestone Aug 31, 2021
@ghost ghost added this to In progress in IEP01 - IntelMQ Configuration Handling via automation Aug 31, 2021
@ghost ghost added bug Indicates an unexpected problem or unintended behavior component: intelmqctl labels Aug 31, 2021
@ghost ghost removed this from In progress in IEP01 - IntelMQ Configuration Handling Aug 31, 2021
@ghost ghost merged commit 5328544 into develop Aug 31, 2021
@ghost ghost deleted the schacht/2084 branch August 31, 2021 15:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: intelmqctl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intelmqctl: 'IntelMQController' object has no attribute 'parameters'
1 participant