Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix logrotate ownership options #2111

Merged
1 commit merged into from
Sep 16, 2021
Merged

BUG: fix logrotate ownership options #2111

1 commit merged into from
Sep 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 14, 2021

The packaged configuration for logrotate falsely contained options applying to other programs' log files. This caused wrong ownerships of log files.
This issues is corrected, but the ownership of affected log files may need to be changed manually.
To find affected files, you may use:

sudo find /var/log/ -user intelmq ! -path \*intelmq\*

fixes #2110

@ghost ghost added bug Indicates an unexpected problem or unintended behavior packaging component: contrib labels Sep 14, 2021
@ghost ghost added this to the 3.1.0 milestone Sep 14, 2021
@ghost ghost requested a review from waldbauer-certat September 14, 2021 14:57
@ghost ghost self-assigned this Sep 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2021

Codecov Report

Merging #2111 (5c96cb1) into develop (e3cfac7) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 5c96cb1 differs from pull request most recent head f01f4dd. Consider uploading reports for the commit f01f4dd to get more accurate results

@@           Coverage Diff            @@
##           develop    #2111   +/-   ##
========================================
  Coverage    76.03%   76.03%           
========================================
  Files          434      434           
  Lines        23222    23222           
  Branches      3106     3106           
========================================
+ Hits         17656    17657    +1     
  Misses        4855     4855           
+ Partials       711      710    -1     
Impacted Files Coverage Δ
intelmq/bots/experts/ripe/expert.py 77.55% <0.00%> (+1.02%) ⬆️

@ghost ghost force-pushed the wagner/fix-2110 branch 2 times, most recently from f01f4dd to 10ed693 Compare September 14, 2021 15:29
The packaged configuration for logrotate falsely contained options applying to other programs' log files. This caused wrong ownerships of log files.
This issues is corrected, but the ownership of affected log files may need to be changed manually.
To find affected files, you may use:
```bash
sudo find /var/log/ -user intelmq ! -path \*intelmq\*
```

fixes #2110
@ghost ghost merged commit 5b3c68b into develop Sep 16, 2021
@sebix sebix deleted the wagner/fix-2110 branch May 23, 2022 05:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: contrib packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logrotate config: global options cause foreign files to be owned
2 participants