TST: also test on python 3.10, switch to pytest #2142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2142 +/- ##
===========================================
+ Coverage 75.93% 76.34% +0.41%
===========================================
Files 440 441 +1
Lines 23630 23649 +19
Branches 3439 3737 +298
===========================================
+ Hits 17943 18055 +112
+ Misses 4956 4857 -99
- Partials 731 737 +6
|
|
nosetest doesn't support Python 3.10 -> We can use unittest itself for running the test or pytest |
sebix
changed the title
nose does not support Python 3.10 and is deprecated. pytest also gives good and nice output, so use this instead in the GitHub Action and in the docs
sebix
force-pushed
the
python-3.10
branch
2 times, most recently
from
dc7898e
to
eb4be3d
Compare
- coverage settings - don't capture warnings, as then logging would not be able to capture them, causing test fails see https://docs.pytest.org/en/6.2.x/warnings.html#disabling-warning-capture-entirely
apparently nose dependes on jinja2 and installed jinja2 implicitly
support the initialization logging message on python 3.10 Python 3.10 returns such a version info: python 3.10.2 (main, Jan 16 2022, 11:55:27) [GCC 9.3.0] the gcc version is now extend the regex to catch this and make it more generic, less complex
- the __init__.py was missing. this was the reason that this test was never executed before with nose - set the overwrite parameter to test the behaviour actually
the old code assumed that there were no command line arguments to the calling program. now set the arguments explicitly to []
|
pytest by default captures all warnings, but we also want to test in our unittest if the capturing of warnings by the logging works. For a simple solution and to keep this PR focused, I chose to disable the warnings capturing in pytest. @aaronkaplan Can you please set the nosetests as optional (not required) in the GitHub settings? Thanks. |
|
looks good. IMHO we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.