Impelment time_format enhancement to use custom time formats #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors. Add unit tests.
sebix
added
feature
waldbauer-certat
requested changes
Jul 13, 2022
| @@ -0,0 +1,2 @@ | |||
| SPDX-FileCopyrightText: 2022 gutsohnCERT | |||
There was a problem hiding this comment.
Suggested change
| SPDX-FileCopyrightText: 2022 gutsohnCERT | |
| SPDX-FileCopyrightText: 2022 CERT.at GmbH |
There was a problem hiding this comment.
I wonder why you want to change the license header from gutsohnCERT to CERT.at Gmbh. That does not make sense for me...
There was a problem hiding this comment.
"gutsohnCERT" was an employee of CERT.at
Comment on lines
+1
to
+9
| # comment with space before | ||
| # comment with tab before | ||
| # comment with mix of tabs and spaces before | ||
| # below line contains spaces only | ||
|
|
||
| # below line contains tabs only | ||
|
|
||
| # below line contains mix of tabs and spaces only | ||
|
|
There was a problem hiding this comment.
Suggested change
| # comment with space before | |
| # comment with tab before | |
| # comment with mix of tabs and spaces before | |
| # below line contains spaces only | |
| # below line contains tabs only | |
| # below line contains mix of tabs and spaces only | |
We could remove those lines, as they are not part of this test.
|
This is superseded by #2329. Close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation and enhancement of time_format parameter to accept custom date formats (Fix #2105). Usage e.g. 'time_format': 'from_format|%d-%m-%Y %H:%M:%S'