Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix ctl process manager initialization non-interactive #2189

Merged
merged 1 commit into from
May 31, 2022

Conversation

wagner-intevation
Copy link
Contributor

@wagner-intevation wagner-intevation commented May 31, 2022

if the intelmq controller class is initiated non-interactively the
process manager instance was not initiated
this caused the intelmqdump tool to crash when retrieving the status of
a bot

fixes #2188

@sebix sebix added bug Indicates an unexpected problem or unintended behavior component: intelmqctl labels May 31, 2022
@sebix sebix added this to the 3.1.0 milestone May 31, 2022
if the intelmq controller class is initiated non-interactively the
process manager instance was not initiated
this caused the intelmqdump tool to crash when retrieving the status of
a bot

fixes certtools#2188
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #2189 (5db3c36) into develop (cda1a9f) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #2189      +/-   ##
===========================================
- Coverage    76.34%   75.93%   -0.41%     
===========================================
  Files          441      441              
  Lines        23649    23318     -331     
  Branches      3739     3434     -305     
===========================================
- Hits         18055    17707     -348     
- Misses        4857     4873      +16     
- Partials       737      738       +1     
Impacted Files Coverage Δ
intelmq/bin/intelmqctl.py 9.19% <0.00%> (-0.12%) ⬇️
intelmq/bots/experts/mcafee/expert_mar.py 35.55% <0.00%> (-8.89%) ⬇️
intelmq/bots/experts/cymru_whois/_lib.py 17.02% <0.00%> (-5.76%) ⬇️
intelmq/bots/experts/modify/expert.py 92.00% <0.00%> (-5.34%) ⬇️
intelmq/bots/parsers/dshield/parser_domain.py 95.45% <0.00%> (-4.55%) ⬇️
intelmq/tests/lib/test_exceptions.py 95.65% <0.00%> (-4.35%) ⬇️
intelmq/bots/experts/abusix/_lib.py 36.84% <0.00%> (-3.16%) ⬇️
intelmq/tests/bots/collectors/rt/test_collector.py 69.44% <0.00%> (-3.06%) ⬇️
intelmq/bots/parsers/dshield/parser_block.py 87.50% <0.00%> (-2.50%) ⬇️
intelmq/bots/collectors/opendxl/collector.py 31.14% <0.00%> (-2.19%) ⬇️
... and 259 more

@sebix sebix merged commit 2efb8c2 into certtools:develop May 31, 2022
@wagner-intevation wagner-intevation deleted the fix-2188 branch May 31, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior component: intelmqctl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

intelmqdump crashes on getting bot status
4 participants