Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove AutoShun from IntelMQ as the feed is discontinued #2214

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

waldbauer-certat
Copy link
Contributor

Feed is discontinued, removing Parser, adding upgrade information.

Fixes #2162

intelmq/lib/upgrades.py Fixed Show fixed Hide fixed
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #2214 (eab1c4d) into develop (80a149a) will decrease coverage by 0.02%.
The diff coverage is 95.23%.

@@             Coverage Diff             @@
##           develop    #2214      +/-   ##
===========================================
- Coverage    76.33%   76.31%   -0.03%     
===========================================
  Files          441      439       -2     
  Lines        23686    23652      -34     
  Branches      3747     3744       -3     
===========================================
- Hits         18081    18050      -31     
+ Misses        4865     4863       -2     
+ Partials       740      739       -1     
Impacted Files Coverage Δ
intelmq/lib/upgrades.py 72.17% <93.33%> (+0.65%) ⬆️
intelmq/tests/lib/test_upgrades.py 100.00% <100.00%> (ø)
intelmq/bots/experts/reverse_dns/expert.py 83.87% <0.00%> (+1.61%) ⬆️

Copy link
Member

@sebix sebix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests for the upgrade function

intelmq/lib/upgrades.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@sebix sebix added this to the 3.1.0 milestone Jul 25, 2022
@sebix sebix added the bug Indicates an unexpected problem or unintended behavior label Jul 25, 2022
@sebix
Copy link
Member

sebix commented Jul 25, 2022

Rebase on develop to fix conflict

@sebix
Copy link
Member

sebix commented Jul 25, 2022

One unittest is failing with

Error: Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v2/dist/codecov' failed with exit code 255

We don't care.

waldbauer-certat and others added 2 commits July 25, 2022 14:52
Fixes #2162

Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
intelmq/tests/lib/test_upgrades.py was reformatted by @waldbauer-certat
in 1eb14d6, fix the excludelines for
codespell now
@sebix sebix merged commit 9635e47 into develop Jul 25, 2022
@sebix sebix deleted the fix-2162 branch July 25, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoshun feed changed/dead
3 participants