Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Added check if cymru hostname is an ip address #2215

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

waldbauer-certat
Copy link
Contributor

Fixes #2169

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #2215 (5e47e4e) into develop (2d7b9ca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2215   +/-   ##
========================================
  Coverage    76.33%   76.33%           
========================================
  Files          441      441           
  Lines        23679    23682    +3     
  Branches      3744     3745    +1     
========================================
+ Hits         18075    18078    +3     
  Misses        4865     4865           
  Partials       739      739           
Impacted Files Coverage Δ
...q/tests/bots/parsers/cymru/test_cap_program_new.py 100.00% <ø> (ø)
intelmq/bots/parsers/cymru/parser_cap_program.py 65.17% <100.00%> (+0.47%) ⬆️

Fixes #2169

Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
@waldbauer-certat waldbauer-certat added this to the 3.1.0 milestone Jul 15, 2022
@waldbauer-certat
Copy link
Contributor Author

Fixed the merge conflict in CHANGELOG.md - Github is sooo fancy 🥳

@waldbauer-certat waldbauer-certat merged commit 236e2fd into develop Jul 15, 2022
@sebix sebix deleted the fix-2169 branch July 15, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cymru parser_cap_program invalid hostname filtering
3 participants