Packaging fixes for Debian, clean deprecated buster from tests #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronkaplan
reviewed
Jul 27, 2023
| @@ -37,7 +37,7 @@ Depends: bash-completion, | |||
| python3-openssl, | |||
| python3-psutil (>= 1.2.1), | |||
| python3-redis (>= 2.10), | |||
| python3-requests (>= 2.2.1), | |||
| python3-requests (>= 2.2.0), | |||
most dependencies lacked the minimum required version that lead to probably false assumptions about installable packages on too old distros
requests is a core dependency, we do not need to require it for the bot
the previous install was hardcoded and outdated on Debian 12 use the distro-default, fixes the build fixes certtools#2384
wagner-intevation
force-pushed
the
fix-pkg
branch
from
705f9db
to
5850b07
Compare
kamil-certat
approved these changes
Sep 5, 2023
|
Rebased the commits on current develop and added an intermediate revision 3.2.1-2, which we could release straightaway |
Support for Debian 10 Buster was dropped in PR#2352 certtools#2352
|
Replacing buster by bullseye in the intelmq tests also required this change in the vagrant test code: certtools/intelmq-vagrant@f824c79 |
|
Some cleanup work after #2352 was missing (buster is no longer supported) and that failed the tests here. Now everything succeeds. |
wagner-intevation
changed the title
kamil-certat
approved these changes
Sep 5, 2023
Time is extremely limited, I'm unsure if it's possible in the next weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is already in home:sebix:intelmq:unstable and the Debian 12 build works.