Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands, better conform with yubiHSM docs #14

Merged
merged 3 commits into from
Apr 9, 2021

Conversation

AndrewPau
Copy link

Added the following commands:

  • PutDerivedAuthenticationKey (same as PutAuthenticationKey except it derives relevant keys from password)
  • GetOpaque
  • PutOpaque
  • SignAttestationCertificate

Added more options/filters for ListObjects and some algorithms & error codes

Also fixed some typos and standardized naming to better conform with the yubiHSM docs

Copy link
Contributor

@hendrikhofstadt hendrikhofstadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Andrew, this is great!

Could you please revert the AuthKey/AuthenticationKey changes? I'd prefer not to break the API and make a major release for this small typo change.

@AndrewPau
Copy link
Author

@hendrikhofstadt fair point, reverted the changes!

Copy link
Contributor

@hendrikhofstadt hendrikhofstadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@hendrikhofstadt hendrikhofstadt merged commit 278b0ae into certusone:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants