Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChangeAuthenticationKey command #8

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

jakecraige
Copy link
Contributor

Introduce the command which is used to change the password to
authenticate to the HSM.

A small refactoring of extracting authkey out was necessary to prevent
an import cycle from securechannel importing commands which (without the
refactor) imported secure channel again.

Documentation for this command: https://developers.yubico.com/YubiHSM2/Commands/Change_Authentication_Key.html

Introduce the command which is used to change the password to
authenticate to the HSM.

A small refactoring of extracting authkey out was necessary to prevent
an import cycle from securechannel importing commands which (without the
refactor) imported secure channel again.

Documentation for this command: https://developers.yubico.com/YubiHSM2/Commands/Change_Authentication_Key.html
@jakecraige
Copy link
Contributor Author

@hendrikhofstadt 🙏 😄

@hendrikhofstadt
Copy link
Contributor

Thanks a lot for this contribution Jake 🎉👍

I'm happy to merge this once the small style issue is resolved.

@jakecraige
Copy link
Contributor Author

@hendrikhofstadt no problem, done

@hendrikhofstadt hendrikhofstadt merged commit 3727364 into certusone:master Feb 28, 2020
@jakecraige jakecraige deleted the jake/upstream-auth branch March 9, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants