Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve timezone offset when parsing datetime properties #8

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

jan-guenter
Copy link
Contributor

Description

For my use case I would highly prefer to have the timezone offset preserved in the resulting datetime objects when properties are parsed.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

This change could break code that does not handle the timezone offset of the datetime data type.

How Has This Been Tested?

Since there are no unit test, I only tested the code in my specific use case.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Disclaimer

I'm a python noob, so please elaborate on potential mistakes I made.

@majurgens
Copy link
Contributor

I need this feature as well

@joente joente merged commit 695034f into cesbit:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants