Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature generation refactor (closes gh-32) #70

Merged
merged 9 commits into from
Oct 1, 2015

Commits on Sep 25, 2015

  1. TCP tests + TODO comments

    Augmented feature generation testing (which currently tests all features
    against previously-computed values) with unit tests for specific
    algorithms. Where possible the tests compare to a priori closed form
    solutions; in a few cases where this isn't practical, we compare to the
    current outputof that function (so these tests are only beneficial
    going forward).
    bnaul committed Sep 25, 2015
    Configuration menu
    Copy the full SHA
    170c851 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2015

  1. Initial refactor of science feature generation

    Move relevant code from TCP library into new path; leave TCP code in
    place for now, but nothing there should be used anywhere at this point.
    bnaul committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    080f07e View commit details
    Browse the repository at this point in the history
  2. Remove mltsp.TCP module

    bnaul committed Sep 28, 2015
    Configuration menu
    Copy the full SHA
    0120754 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fced01b View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2015

  1. Configuration menu
    Copy the full SHA
    57243c7 View commit details
    Browse the repository at this point in the history
  2. Refactor lc_tools feature generation

    Remove unnecessary code from lc_tools module that is not used for
    feature generation; use dask for computing feature values, in the same
    way as is now done for science_features.
    bnaul committed Sep 29, 2015
    Configuration menu
    Copy the full SHA
    5f812c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2015

  1. Improve consistency throughout feature generation

    Naming conventions and implementation details were inconsistent between
    `lc_tools` (now `obs_feature_tools`), `science_feature_tools`, and in
    various other places throughout the featurization pipeline. Improves
    consistency within these areas and removes some deprecated/unnecessary
    logic, including 1) featurization of a single time series now always
    returns a dict, instead of sometimes a list containing a single dict;
    2) `short_fname` keys into dictionaries are now always the filename
    without the extension (previously the extension was included in some
    places and not others).
    
    Undo test_prediction_page sleep change
    bnaul committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    369cede View commit details
    Browse the repository at this point in the history
  2. Revert "Remove mltsp.TCP module"

    This reverts commit 0120754.
    For now, restore TCP module to simplify the refactor pull request. Will
    remove TCP later after the replacement code has been merged.
    bnaul committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    7c54921 View commit details
    Browse the repository at this point in the history
  3. Remove old import + other style changes

    Tidying up: remove import of deprecated `lc_tools`, add a couple tests
    for `obs_feature_tools`, change some test data, remove extraneous
    comments, add a couple of docstrings, change `test_flask_app` database
    teardown procedure.
    bnaul committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    2660c11 View commit details
    Browse the repository at this point in the history