New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory footprint, reduce OOMs, share threads for connected clients #18

Merged
merged 1 commit into from Jan 13, 2018

Conversation

Projects
None yet
2 participants
@troyunverdruss
Contributor

troyunverdruss commented Dec 18, 2017

By default, each connected client gets assigned an unnamed single thread scheduled thread pool. When tens of thousands of clients are connected, this consumes a massive amount of memory, often resulting in an OOM. This change dedicates a scheduler thread and a pool of workers to be shared among all connected clients (also the thread pools are named for easier debugging in the future)

By default, each connected client gets assigned an unnamed single thr…
…ead scheduled thread pool. When tens of thousands of clients are connected, this consumes a massive amount of memory, often resulting in an OOM. This change dedicates a scheduler thread and a pool of workers to be shared among all connected clients (also the thread pools are named for easier debugging in the future)
@troyunverdruss

This comment has been minimized.

Show comment
Hide comment
@troyunverdruss

troyunverdruss Dec 18, 2017

Contributor

^^ Looks like the travis config is possibly broken

Contributor

troyunverdruss commented Dec 18, 2017

^^ Looks like the travis config is possibly broken

@flowersinthesand flowersinthesand merged commit abffc4b into cettia:master Jan 13, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@flowersinthesand

This comment has been minimized.

Show comment
Hide comment
@flowersinthesand

flowersinthesand Jan 13, 2018

Member

@troyunverdruss Yes it was due to travis-ci/travis-ci#7884 (comment) so I'll drop oraclejdk7. Thanks for your contribution!

Member

flowersinthesand commented Jan 13, 2018

@troyunverdruss Yes it was due to travis-ci/travis-ci#7884 (comment) so I'll drop oraclejdk7. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment