Reduce memory footprint, reduce OOMs, share threads for connected clients #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead scheduled thread pool. When tens of thousands of clients are connected, this consumes a massive amount of memory, often resulting in an OOM. This change dedicates a scheduler thread and a pool of workers to be shared among all connected clients (also the thread pools are named for easier debugging in the future)
|
^^ Looks like the travis config is possibly broken |
flowersinthesand
approved these changes
Jan 13, 2018
|
@troyunverdruss Yes it was due to travis-ci/travis-ci#7884 (comment) so I'll drop oraclejdk7. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, each connected client gets assigned an unnamed single thread scheduled thread pool. When tens of thousands of clients are connected, this consumes a massive amount of memory, often resulting in an OOM. This change dedicates a scheduler thread and a pool of workers to be shared among all connected clients (also the thread pools are named for easier debugging in the future)