mark: Support placing marks post-transform #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannes-wolf
added
enhancement ⬆️
|
… or should we even do this by default (without an option)? This is what TikZ does. Marks don't get scaled with shape-transforms. What do you think @fenjalien? I'd really like to have this feature. |
|
Together with #505 this would bring marks closer to how Tikz handles them. |
fenjalien
requested changes
Feb 14, 2024
johannes-wolf
force-pushed
the
mark-post-transform
branch
3 times, most recently
from
52584ee
to
36e705b
Compare
johannes-wolf
force-pushed
the
mark-post-transform
branch
from
36e705b
to
6dc8fa3
Compare
johannes-wolf
force-pushed
the
mark-post-transform
branch
from
6dc8fa3
to
d27e77c
Compare
fenjalien
reviewed
Feb 19, 2024
fenjalien
approved these changes
Feb 20, 2024
johannes-wolf
added a commit
that referenced
this pull request
Feb 21, 2024
Change the default transformation matrix to have z coordinates of zero after transformation. This is actually a fix, as the final 2D projection should not have a z-value other than zero. With this change, anchors in 3D space become 2D and thus elements like rect, Bézier or Catmull, … will correctly work when using them with anchors to 3D elements. Intersection between 3D elements will also work (in 2D space). See: #502 and #493.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows placing marks after the path got transformed.
Use-Case: drawing marks on scaled paths, drawing marks insides plots (which use a scaled viewport). The behavior is disabled by default and can be enabled by setting marks
post-transformstyle key totrue.Maybe the implementation has too much copied code, but doing the transform insides
mark.typis also not that clean I think.