Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 1.8 class files warning #2163

Closed
lucaswerkmeister opened this issue May 16, 2015 · 14 comments
Closed

Remove 1.8 class files warning #2163

lucaswerkmeister opened this issue May 16, 2015 · 14 comments

Comments

@lucaswerkmeister
Copy link
Member

Java 7 has reached end of life, and there aren’t any known Java 8-specific issues, so I suggest we remove the following warning:

warning: It looks like you are using class files from a Java newer than 1.7.
  Everything should work well, but if not, let us know at https://github.com/ceylon/ceylon-compiler/issues.
  In the near future, the Ceylon compiler will be upgraded to handle Java 1.8.

because it’s now obsolete.

@gavinking
Copy link
Member

+1

1 similar comment
@luolong
Copy link
Member

luolong commented May 16, 2015

+1

@FroMage FroMage modified the milestone: 1.2 Jun 1, 2015
@FroMage
Copy link
Member

FroMage commented Jun 3, 2015

Well, I could remove it, but I'd have to replace it with "actually you can't compile to Java 8 bytecode so you can't use default methods"

@FroMage
Copy link
Member

FroMage commented Jun 16, 2015

Moving to 1.3.

@FroMage FroMage modified the milestones: 1.3, 1.2 Jun 16, 2015
@gavinking
Copy link
Member

Huh?!

I think we should remove this warning. It's very annoying and useless.

@lucaswerkmeister
Copy link
Member Author

I agree. Being unable to use default methods is just another interop problem, there’s no need to warn people about it every time they compile anything at all (even if it’s pure Ceylon code).

@gavinking
Copy link
Member

Or, y'know, give them an error if and when they try to call a default method.

@gavinking
Copy link
Member

I mean, a problem with the current warning is after seeing only about 1k times, I still didn't know I couldn't call default methods in Ceylon.

@FroMage
Copy link
Member

FroMage commented Jun 16, 2015

Well, I did suggest to change the error message, but nobody answered.

@jvasileff
Copy link
Member

+1 for eliminating the message.

The impression I got from this warning when I first saw it was 180º off - that Ceylon might be stale and lacking momentum.

I think it's fine letting folks discover that ceylon compile can't compile newer Java sources on their own, without the bad marketing and compromised UI.

@lucaswerkmeister
Copy link
Member Author

Can we please remove this warning? “Everything should work well, but if not, let us know” sounds like a cover-our-asses statement because we didn’t test whether we work on 8, which isn’t true at all – by now, we’re very sure that everything we support also works on Java 8. A warning that we don’t support lambdas would be more fitting on an import java.base "8" statement in my opinion. (Though then it would suck that you can’t import java.base without warnings.)

@FroMage FroMage modified the milestones: 1.2, 1.3 Jul 1, 2015
@FroMage
Copy link
Member

FroMage commented Jul 1, 2015

OK fine.

FroMage added a commit that referenced this issue Jul 6, 2015
@FroMage
Copy link
Member

FroMage commented Jul 6, 2015

Done, halleluia

@FroMage FroMage closed this as completed Jul 6, 2015
@lucaswerkmeister
Copy link
Member Author

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants