Streamline command prompt string generation #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added better error handling as well.
I've tried not to change too many things, but I did cleanup some basic things like the
HasArgs
methodI've moved all the "items" of the command prompt (hostname, username, etc) into one file, and rather than implement a bespoke method like
Print
I've just implemented a String representation of it, so that callingfmt.Println
on theCmdPrompt
struct prints the prompt.Fixes the following bugs
#4 Control+D sends gosh into an infinite loop
#5 Pressing Enter on an empty command will throw a stracktrace