#58: Fix pasting JSON parameter set which was send via MsTeams #59
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Havret
reviewed
Mar 23, 2023
| @@ -476,6 +476,8 @@ public async void PasteParametersSetup() | |||
| try | |||
| { | |||
| var actualPayload = payload.Substring(first, (last+1) - first); | |||
| //INFO: When you send JSON via MSTeams, you will get extra non-breaking spaces on the other side. Those extra white-spaces breaks deserializer | |||
| actualPayload = actualPayload.Replace(" \u00A0", " "); | |||
There was a problem hiding this comment.
Wouldn't it be enough to do:
actualPayload = actualPayload.Replace("\u00A0", "");
There was a problem hiding this comment.
I thought about that, but what if the value contains intentionally non-breaking space? For me, it's a valid use case. On the other hand, non-breaking space following regular space seems to be a little weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.