Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML schema definition file #433

Closed
larsbarring opened this issue Dec 21, 2023 · 9 comments · Fixed by #458
Closed

XML schema definition file #433

larsbarring opened this issue Dec 21, 2023 · 9 comments · Fixed by #458
Labels
enhancement Enhancements to the website's presentation or contents

Comments

@larsbarring
Copy link
Contributor

larsbarring commented Dec 21, 2023

The standard name XML file refers to a XSD file:

<standard_name_table xsi:noNamespaceSchemaLocation="cf-standard-name-table-1.1.xsd">

The only such file I have been able to locate is from the days of table version 13:
.../cf-convention.github.io/Data/cf-standard-names/13/src/cf-standard-name-table-1.1.xsd

Is this the currently used one, or is there a more recent one offline somewhere at CEDA?

I am asking because over at the cf-conventions repo there are three issues that likely involve modifications to this file:
cf-conventions/#132, cf-conventions/#367, cf-conventions/#500

@larsbarring
Copy link
Contributor Author

larsbarring commented Jan 13, 2024

Investigating this somewhat more in detail by looking at what .xsd files are available with which version of the standard name table, and what file is referred to in the xml file, the following emerges (see table below):

  • There are three filenames CFStandardNameTable-1.0.xsd, CFStandardNameTable-1.1.xsd, and
    cf-standard-name-table-1.1.xsd
  • CFStandardNameTable-1.0.xsd is applicable only for version 1.
  • CFStandardNameTable-1.1.xsd and cf-standard-name-table-1.1.xsd have exactly the same content.
  • In version 13 the name of the file changed from CFStandardNameTable-1.1.xsd to cf-standard-name-table-1.1.xsd. This change was not followed by a corresponding change, neither in the xml file, nor of the format specification in Appendix B of the conventions document.
  • The xsd file has not been systematically transferred when a new version was produced. Onwards from version 14 the file is not present.
Ver. XSD pointed at in xml file XSD file in directory XSD file size Duplicate (unused) file
1 CFStandardNameTable-1.0.xsd CFStandardNameTable-1.0.xsd 3183  
2 CFStandardNameTable-1.1.xsd CFStandardNameTable-1.1.xsd 3696 CFStandardNameTable-1.0.xsd
3 CFStandardNameTable-1.1.xsd CFStandardNameTable-1.1.xsd 3696 CFStandardNameTable-1.0.xsd
4 CFStandardNameTable-1.1.xsd      
5 CFStandardNameTable-1.1.xsd CFStandardNameTable-1.1.xsd 3696 CFStandardNameTable-1.0.xsd
6 CFStandardNameTable-1.1.xsd --    
7 CFStandardNameTable-1.1.xsd CFStandardNameTable-1.1.xsd 3696  
8 CFStandardNameTable-1.1.xsd CFStandardNameTable-1.1.xsd 3696  
9 CFStandardNameTable-1.1.xsd --    
10 CFStandardNameTable-1.1.xsd CFStandardNameTable-1.1.xsd 3696  
11 CFStandardNameTable-1.1.xsd CFStandardNameTable-1.1.xsd 3696  
12 CFStandardNameTable-1.1.xsd --    
13 CFStandardNameTable-1.1.xsd cf-standard-name-table-1.1.xsd 3696  
14 CFStandardNameTable-1.1.xsd --    
15 CFStandardNameTable-1.1.xsd --    
16 CFStandardNameTable-1.1.xsd --    
17 cf-standard-name-table-1.1.xsd --    
18 cf-standard-name-table-1.1.xsd --    
19 cf-standard-name-table-1.1.xsd --    
20-84 ... and so on ...

EDIT: Updated to xsd filename given in the xml file from version 17 and later /LB

@larsbarring
Copy link
Contributor Author

larsbarring commented Jan 15, 2024

Attached below is a suggestion for an updated version of the xsd file that takes care (I hope) of the changes proposed in
cf-/conventions/#132, cf-/conventions/#367, cf-/conventions/#500. Rather than removing elements I have for transparency commented them out (for later removal).

Note that the changes suggested in the three issues will require updates to the cf-vocab-editor as well as the file
...../xsl/html/cf-standard-name-table-1.3.xsl

The .txt extension was added just to allow uploading here, and it can/should be removed before any use.
CFStandardNameTable-1.2.xsd.txt

EDIT 2024-02-28: Upon further analysis the attached xsd file is not longer up-to-date (only approximately right) /LB

@larsbarring
Copy link
Contributor Author

larsbarring commented Feb 28, 2024

Instead of having the schema files scattered in various uncoordinated version subdirectories as per the table above I suggest that they are collected in one specifically designated subdirectory. This will help to get a better overview and facilitate their publication in the website. See associated pull request for technical details.

@JonathanGregory
Copy link
Contributor

That looks sensible, thanks. I'm happy to support it if Alison @japamment supports it too.

@davidhassell
Copy link
Contributor

All looks good to me, too.

@larsbarring
Copy link
Contributor Author

Thanks, David @davidhassell, would you mind also having a look at cf-conventions#511, which is a simple enhancement proposal still in need of support --- or criticism for that matter :-)

@japamment
Copy link
Member

Hi @larsbarring @JonathanGregory,

I am happy with the proposal in this issue to collect the xsd schema files into one directory. I'm also happy with pull request #458 which implements it - I think it is fine to go ahead and merge the pull request.

In addition, I have added some comments in cf-conventions/issues/132 which allows one alias to be split into two standard names and cf-conventions/issues/367 regarding removal of the grib and amip columns from the standard name table. Although simple in concept, conventions issue 367 is a larger change in practice, and I think it best to prioritise completion of this current issue and cf-conventions/issues/132 before tackling that one.

@larsbarring
Copy link
Contributor Author

Many thanks Alison !

With this I think that we can start the countdown clock. If there are no more (substantial) comments regarding this enhancement proposal the associated PR could be merged on April 10.

I fully agree that removing the amip and grib columns of the standard name table is a larger undertaking that should wait until all these changes are completed.

@larsbarring
Copy link
Contributor Author

As this enhancement proposal is supported by several (@JonathanGregory, @davidhassell, @japamment) and there have been no further comments during the count-down period, I think this proposal can now be accepted. Could someone please merge the associate PR #458.

Many thanks,
Lars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to the website's presentation or contents
Projects
None yet
4 participants