Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publication of the standard name table XML schema file on the website #469

Closed
larsbarring opened this issue Mar 20, 2024 · 11 comments · Fixed by #472
Closed

Publication of the standard name table XML schema file on the website #469

larsbarring opened this issue Mar 20, 2024 · 11 comments · Fixed by #472
Labels
enhancement Enhancements to the website's presentation or contents

Comments

@larsbarring
Copy link
Contributor

larsbarring commented Mar 20, 2024

This is one in a string of issues that aims to improve the format of the XML version of the standard name table files, see #457 for background and overview.

This particular issue directly builds on #459 , which implements a unified version of the XML standard name table format, as specified in Appendix B, and which is applicable to all published version of the XML file.

To comply with the XML syntax the schema file (.xsd), if present at all, needs to be specified in a way that is reachable for the software consuming XML file. Currently this is not the case, and the best way to do this is to publish the file on the web site. Thus, the proposal is to add a new line under the heading "Documents" on the Vocabularies page.

Currently it reads:

Documents
Guidelines for Construction of CF Standard Names
List of contributors to CF Standard Names
[Rules][vocabrules] for making changes to the CF vocabularies

Proposal:

Documents
Guidelines for Construction of CF Standard Names
List of contributors to CF Standard Names
[Rules][vocabrules] for making changes to the CF vocabularies
Schema file for the Standard name table XML files (version 1 -- current)

The last line is bold to only highlight the addition. This addition will make it possible to provide a robust link to the the schema file from within the XML standard name table files, which will be dealt with in a separate issue.

@larsbarring
Copy link
Contributor Author

The associated draft PR (#472) should be activated only after PR #468 has been merge because in that PR the directory structure is established.

But the actual change to the layout of the *vocabularies web page, which is in focus for this issue is independent of where the link actually points to.

@JonathanGregory
Copy link
Contributor

Thanks, @larsbarring. That makes sense. I support this change.

The text of the link says it's version 1, but the link itself is to your new version 2.0.

Would it be in order for you to fix the line above as well, which is rendered as "[Rules][vocabrules]"? Presumably it should be "Rules" as HTML link text.

@larsbarring
Copy link
Contributor Author

Regarding your first comment I think you mean "(version 1 -- current)". This is as intended because this new schema file should apply to all versions until we decide to change to the XML format, e.g. by removing AMIP and GRIB, where I totally agree with Alison in that it should be handled later and as a totally independent issue (that this string of issues nevertheless paves the way for). It also means that all published XML files should be processed to include this new link (this is central to this whole effort).

Regarding your second comment, I saw the strange "link", but did not know what to make of it. I also saw a couple of other link issues on the same page; the version 83 HTML and XML links actually point to version 82, and for the KWIK links there are duplicates for version 82. In fact I would prefer not to deal with those issues:

Firstly, I would like to focus on this rather complex string of issues and associated PRs.

Secondly the other link issues on the vocabularies page could (should preferably, I would say) be handled as part of #408, which again connects to the standard name publication process, but from a totally different angle than what is dealt with here.

@JonathanGregory
Copy link
Contributor

Dear @larsbarring

Regarding your first comment I think you mean "(version 1 -- current)". This is as intended because this new schema file should apply to all versions until we decide to change to the XML format.

Yes, that's what I meant, and I agree it should. But the new scheme file is version 2.0, isn't it, not "version 1 -- current"?

Yes, it's fine to leave the smaller errors on the vocabulary page to a separate issue.

#408 is about adding a link to https://cfconventions.org/Data/cf-standard-names/current/src/cf-standard-name-table.xml, if that intended always to be a link to latest xml. Do you think it is? I can do that PR myself, if that's correct, since it was my issue.

Best wishes

Jonathan

larsbarring added a commit to larsbarring/cf-convention.github.io that referenced this issue Mar 25, 2024
Regarding cf-convention#469:
Just to test the workflow the current XSD link in XML files
points to my repo.
@larsbarring
Copy link
Contributor Author

Thanks Jonathan @JonathanGregory,

If I change the wording to

Schema file for all versions (1 -- current) of the Standard name table XML files.

is that clearer? Or do you think that we explicitly need to mention the version of the schema file as such? The mockup link points to the right (*) place and file name. If someone wants to download the file it will be the right version (2.0). Otherwise, the (main) aim with this link is to provide a robust uri that is included in all XML files.

I have not touched the old/present version (1.3) of the schema files that I believe are present for all version of the standard name table as Data/cf-standard-names/$version$/xsl/html/cf-standard-name-table-1.3.xsl.

(*) If #433 is accepted without changes.

larsbarring added a commit to larsbarring/cf-convention.github.io that referenced this issue Mar 26, 2024
Regarding cf-convention#469:
Just to test the workflow the current XSD link in XML files
points to my repo.
larsbarring added a commit to larsbarring/cf-convention.github.io that referenced this issue Mar 26, 2024
Regarding cf-convention#469:
Just to test the workflow the current XSD link in XML files
points to my repo.
@JonathanGregory
Copy link
Contributor

Sorry, @larsbarring, I had misunderstood "(1 -- current)". I thought it meant that "1" is the current version, with "--" as a dash, rather than indicating a numerical range, which makes more sense! Probably others wouldn't make this mistake; that was just unlucky. On the other hand, you could omit "(1 -- current)". I would not have misunderstood "Schema file for all versions". Jonathan

@larsbarring
Copy link
Contributor Author

Dear Jonathan,
No worries -- thanks for your input :-)
PR has been updated.
Lars

@larsbarring
Copy link
Contributor Author

With the comments above I think that we can start the countdown clock, which means that the associated PR can be merged after #468, but at the earliest on April, 17.

@larsbarring
Copy link
Contributor Author

The associated PR is now ready to be merged. A test publication is available here.

Regarding the errors in the vocabulariesweb page, mentioned in passing here and here, they were fixed via #408.

@larsbarring
Copy link
Contributor Author

Hi @sadielbartholomew,

May I again make use of you expertise to have a look at the associated PR #472, which is a really small one-line change, and merge it if you are satisfied.

(After that there is just one more small issue cf-conventions/#516 to close before the main act in #470, which has no PR at the moment.)

Many thanks,
Lars

@sadielbartholomew
Copy link
Member

Sure, thanks for raising that PR Lars. Since it is small to review I will do it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to the website's presentation or contents
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants