Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NUG link to Data Types in ch02.adoc #458

Closed
larsbarring opened this issue Sep 18, 2023 · 4 comments · Fixed by #444
Closed

Update NUG link to Data Types in ch02.adoc #458

larsbarring opened this issue Sep 18, 2023 · 4 comments · Fixed by #444
Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors

Comments

@larsbarring
Copy link
Contributor

larsbarring commented Sep 18, 2023

@bzah found a broken link to NUG in chapter 2.2 Data Types and located the correct link. With the recent enhancement of the text related to packing/unpacking (#374 and #456) this link even more relevant. Thanks Abel for spotting this!

Would you @bzah mind also updating the history (cf. history.adoc in the PR)

Associated pull request

#444

As the PR was created already on August 9, I believe it can be merged as soon as ready, i.e. without the cool down period.

@larsbarring larsbarring added the defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors label Sep 19, 2023
@bzah
Copy link
Contributor

bzah commented Oct 6, 2023

Hi, thanks Lars for opening the issue.
I don't have anything else to add to the PR, can we merge this now ?

@JonathanGregory
Copy link
Contributor

Thanks for opening the issue, @larsbarring, and thanks for finding and fixing the problem, Abel @bzah. Please could you add a line for this issue at the top of history.adoc? I think the format should be obvious from the existing entries. Once that is in place in your PR, we can merge it.

@bzah
Copy link
Contributor

bzah commented Oct 11, 2023

I read the issue too quickly and didn't catch that the history.adoc update was needed.
It's now done.

@JonathanGregory JonathanGregory linked a pull request Oct 11, 2023 that will close this issue
@JonathanGregory
Copy link
Contributor

Thanks, @bzah and @larsbarring. I will merge it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants