Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple correction to Example 6.1.2 #490

Closed
larsbarring opened this issue Nov 27, 2023 · 5 comments
Closed

Simple correction to Example 6.1.2 #490

larsbarring opened this issue Nov 27, 2023 · 5 comments
Labels
change agreed Accepted for inclusion in the next version defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors
Milestone

Comments

@larsbarring
Copy link
Contributor

I have just come across a suggested correction in PR cf-convention/cf-convention.github.io#216 by @Fred-Leclercq. Basically he notes that in the example the standard name does not exists and suggests an alternative, i.e. the following change:

abundance:standard_name = "number_concentration_of_organisms_in_taxon_in_sea_water" ;
abundance:standard_name = "number_concentration_of_biological_taxon_in_sea_water" ;

As I have no insight into this subject area, could some else have a look? Moreover, it might be easier to create a new PR using the current draft (and then in this repo) rather than trying to update the current one in the other repo.

ping @JonathanGregory (as you might know yourself, or know who has the right expertise)

@larsbarring larsbarring added the defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors label Nov 27, 2023
@davidhassell
Copy link
Contributor

Hi Lars,

I wrote PR #219 that put that in :) and think that @Fred-Leclercq's analysis is correct - the standard name in the example should be number_concentration_of_biological_taxon_in_sea_water, as introduced by @roy-lowry in cf-convention/discuss#27. We should close cf-convention/cf-convention.github.io#216 (as it suggests a change to an actual published version) and create a new PR here, as you suggest.

@JonathanGregory
Copy link
Contributor

I agree. Thanks, both.

@larsbarring
Copy link
Contributor Author

OK, I will prepare a PR.

@larsbarring larsbarring added this to the 1.11 milestone Nov 28, 2023
@larsbarring
Copy link
Contributor Author

Hi David @davidhassell I put you as reviewer of the PR. As the PR takes care of a simple correction I suggest that it can be merged ass soon as it is accepted.

@larsbarring larsbarring added the change agreed Accepted for inclusion in the next version label Nov 28, 2023
@larsbarring
Copy link
Contributor Author

larsbarring commented Nov 28, 2023

Closed as completed via PR #492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change agreed Accepted for inclusion in the next version defect Conventions text meaning not as intended, misleading, unclear, has typos, format or language errors
Projects
None yet
Development

No branches or pull requests

3 participants