Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

side-by-side formatting for three-way ranking task #19

Merged
merged 5 commits into from
Jul 11, 2012

Conversation

mjpost
Copy link
Collaborator

@mjpost mjpost commented Jul 10, 2012

This is fixed to use the built-in CSS classes instead of introducing percentage-based spacing.

One unimplemented feature is that I would like to capture "<", "=", and ">" keys for easy annotation. Typing "<" would select Translation A as the best, submit it, and move to the next task. I couldn't get this working with the JQuery $(document).keyup() function.

@cfedermann
Copy link
Owner

Keyboard shortcuts ARE already there... You can use
[Your-OS-Browser-Modifier]+1/2/3/4 to access any of the four buttons
directly.

This works for all tasks :)

For a Mac using Safari, this should be Ctrl-Alt-1/2/3/4

On Tue, Jul 10, 2012 at 7:55 PM, Matt Post <
reply@reply.github.com

wrote:

This is fixed to use the built-in CSS classes instead of introducing
percentage-based spacing.

One unimplemented feature is that I would like to capture "<", "=", and
">" keys for easy annotation. Typing "<" would select Translation A as the
best, submit it, and move to the next task. I couldn't get this working
with the JQuery $(document).keyup() function.

You can merge this Pull Request by running:

git pull https://github.com/mjpost/Appraise master

Or you can view, comment on it, or merge it online at:

#19

-- Commit Summary --

  • changed 3-way classification to side-by-side formatting
  • reformatted, removed special percentage CSS classes
  • added (nonworking) $(document).keyup() function stub

-- File Changes --

M appraise/templates/evaluation/three_way_ranking.html (32)

-- Patch Links --

https://github.com/cfedermann/Appraise/pull/19.patch
https://github.com/cfedermann/Appraise/pull/19.diff


Reply to this email directly or view it on GitHub:
#19

@mjpost
Copy link
Collaborator Author

mjpost commented Jul 10, 2012

Where is that defined? It would be nice to assign something more intuitive (or, in the least, we should add some text to the page alerting users)

On Jul 10, 2012, at 2:08 PM, Christian Federmann wrote:

Keyboard shortcuts ARE already there... You can use
[Your-OS-Browser-Modifier]+1/2/3/4 to access any of the four buttons
directly.

This works for all tasks :)

On a Mac using Safari, this should be Ctrl-Alt-1/2/3/4

On Tue, Jul 10, 2012 at 7:55 PM, Matt Post <
reply@reply.github.com

wrote:

This is fixed to use the built-in CSS classes instead of introducing
percentage-based spacing.

One unimplemented feature is that I would like to capture "<", "=", and
">" keys for easy annotation. Typing "<" would select Translation A as the
best, submit it, and move to the next task. I couldn't get this working
with the JQuery $(document).keyup() function.

You can merge this Pull Request by running:

git pull https://github.com/mjpost/Appraise master

Or you can view, comment on it, or merge it online at:

#19

-- Commit Summary --

  • changed 3-way classification to side-by-side formatting
  • reformatted, removed special percentage CSS classes
  • added (nonworking) $(document).keyup() function stub

-- File Changes --

M appraise/templates/evaluation/three_way_ranking.html (32)

-- Patch Links --

https://github.com/cfedermann/Appraise/pull/19.patch
https://github.com/cfedermann/Appraise/pull/19.diff


Reply to this email directly or view it on GitHub:
#19


Reply to this email directly or view it on GitHub:
#19 (comment)

@cfedermann
Copy link
Owner

See the HTML source code, accesskey settings are defined in the corresponding templates/xzy.html files:

<div class="actions">
  <button class="btn" name="submit_button" accesskey="1" type="submit" value="ACCEPTABLE"><i class="icon-ok"></i> Acceptable</button>
  &nbsp;

  <button class="btn" name="submit_button" accesskey="2" type="submit" value="CAN_EASILY_BE_FIXED"><i class="icon-pencil"></i> Can easily be fixed</button>
  &nbsp;

  <button class="btn" name="submit_button" accesskey="3" type="submit" value="NONE_OF_BOTH"><i class="icon-remove"></i> None of both</button>
  &nbsp;

  <button class="btn btn-danger" name="submit_button" accesskey="4" type="submit" value="FLAG_ERROR"><i class="icon-exclamation-sign icon-white"></i> Flag Error</button>
</div>

1,2,3,4 are somewhat intuitive as they are used for all tasks; I tried task-based mnemonics before but finally decided against them due to "letter clashes" and reduced processing speed due to changing keyboard patterns...

@mjpost
Copy link
Collaborator Author

mjpost commented Jul 10, 2012

Ah, thanks. Do you know how to make it work without the use of meta-keys? i.e., I'd like to be able to type '1' instead of 'CTRL-CMD-1'. I did some digging but didn't come up with an easy answer.

matt

On Jul 10, 2012, at 2:31 PM, Christian Federmann wrote:

See the HTML source code, accesskey settings are defined in the corresponding templates/xzy.html files:

Acceptable  
 <button class="btn" name="submit_button" accesskey="2" type="submit" value="CAN_EASILY_BE_FIXED"><i class="icon-pencil"></i> Can easily be fixed</button>
 &nbsp;

 <button class="btn" name="submit_button" accesskey="3" type="submit" value="NONE_OF_BOTH"><i class="icon-remove"></i> None of both</button>
 &nbsp;

 <button class="btn btn-danger" name="submit_button" accesskey="4" type="submit" value="FLAG_ERROR"><i class="icon-exclamation-sign icon-white"></i> Flag Error</button>

1,2,3,4 are somewhat intuitive as they are used for all tasks; I tried task-based mnemonics before but finally decided against them due to "letter clashes" and reduced processing speed due to changing keyboard patterns...


Reply to this email directly or view it on GitHub:
#19 (comment)

@cfedermann
Copy link
Owner

I don't think there's an easy or browser/OS-independent way of doing that :(

Will check jQuery docs again tomorrow :)

On Tue, Jul 10, 2012 at 10:42 PM, Matt Post <
reply@reply.github.com

wrote:

Ah, thanks. Do you know how to make it work without the use of meta-keys?
i.e., I'd like to be able to type '1' instead of 'CTRL-CMD-1'. I did some
digging but didn't come up with an easy answer.

matt

On Jul 10, 2012, at 2:31 PM, Christian Federmann wrote:

See the HTML source code, accesskey settings are defined in the
corresponding templates/xzy.html files:

Acceptable  
 <button class="btn" name="submit_button" accesskey="2"

type="submit" value="CAN_EASILY_BE_FIXED"> Can
easily be fixed
 

 <button class="btn" name="submit_button" accesskey="3"

type="submit" value="NONE_OF_BOTH"> None of
both
 

 <button class="btn btn-danger" name="submit_button" accesskey="4"

type="submit" value="FLAG_ERROR"> Flag Error

1,2,3,4 are somewhat intuitive as they are used for all tasks; I
tried task-based mnemonics before but finally decided against them due to
"letter clashes" and reduced processing speed due to changing keyboard
patterns...


Reply to this email directly or view it on GitHub:
#19 (comment)


Reply to this email directly or view it on GitHub:
#19 (comment)

@cfedermann
Copy link
Owner

Update: 1,2,3,4 key-only implementation coming later today...

cfedermann pushed a commit that referenced this pull request Jul 11, 2012
@cfedermann cfedermann merged commit fb23c74 into cfedermann:master Jul 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants