Fixes #6604: handle SIGHUP for cf-serverd

[ncharles]

See https://dev.cfengine.com/issues/6604

[cfengine-review-bot]

Can one of the admins verify this patch?

[basvandervlies]

+1

[kacf]

Why doesn't this follow the same code path as below? Wouldn't it be better to do something like:

-    if (config->agent_specific.daemon.last_validated_at < validated_at)
+    if (config->agent_specific.daemon.last_validated_at < validated_at
+        || IsRequestReloadConfig())
     {
+        if (IsRequestReloadConfig())
+        {
+            ClearRequestReloadConfig();
+            validated_at = time(NULL);
+        }
         /* Rereading policies now, so update timestamp. */

or something along those lines.

[ncharles]

i didn't want to modify manually the validated_at, and forcing a promise reload sounded more sensible, for instance if new promises are invalid, it would still use the previous set

[ncharles]

If you want, I can move the block within the
if (config->agent_specific.daemon.last_validated_at < validated_at || IsRequestReloadConfig())

[kacf]

Looks sensible to handle SIGHUP in this way though.

[jimis]

Thanks! I just commented on redmine 6604 to figure out if we really want this. Code issues can be reviewed later. :-)

[cfengine-review-bot]

Can one of the admins verify this patch?

[cfengine-review-bot]

Can one of the admins verify this patch?

[kacf]

Merged with many additional fixes in d0547c2.