Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5573: have cf-serverd understands SIGHUP #490

Conversation

ncharles
Copy link
Member

No description provided.

@ncharles
Copy link
Member Author

see also cfengine/core#2008

@jooooooon
Copy link
Member

The patch seems to be missing from this PR!

@ncharles ncharles force-pushed the ust_5571/int/5573_cf_serverd_understand_sighup branch from a14b8ee to 2dda830 Compare September 26, 2014 15:50
@ncharles
Copy link
Member Author

indeed, i like suspens :)

time_t validated_at = ReadTimestampFromPolicyValidatedFile(config, NULL);

- if (config->agent_specific.daemon.last_validated_at < validated_at)
+ if (config->agent_specific.daemon.last_validated_at < validated_at )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated, and not conform with CFEngine's syntax guide

@jooooooon
Copy link
Member

This looks good to me. Let's wait and see what happens in the PR on cfengine/core, and if it looks OK in a few days, merge this.

@peckpeck
Copy link
Member

this PR is nor meageable anymore

@ncharles ncharles force-pushed the ust_5571/int/5573_cf_serverd_understand_sighup branch from 2dda830 to 2abd3ef Compare November 12, 2014 10:30
@ncharles ncharles force-pushed the ust_5571/int/5573_cf_serverd_understand_sighup branch from 2abd3ef to a1577f5 Compare November 12, 2014 10:30
@ncharles
Copy link
Member Author

PR has been updated

VinceMacBuche added a commit that referenced this pull request Nov 12, 2014
…derstand_sighup

Fixes #5573: have cf-serverd understands SIGHUP
@VinceMacBuche VinceMacBuche merged commit 4d7c5cb into Normation:branches/rudder/2.11 Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants