Redmine#7166: data_expand() function #2207
Conversation
|
Can one of the admins verify this patch? |
|
@kacfengine @estenberg this would be very useful to have in 3.7. Right now we have to either reconstruct data containers into classic arrays. Or we have to use parsejson and we are limited to 4K. And looping over "large" arrays has shown dramatic performance implications. |
|
The function is very contained and does not touch any of the rest of the core. I think it's fairly safe even at this late stage. |
|
This will be very useful for EFL. I hope it can make it to 3.7. |
| const Rlist *args) | ||
| { | ||
| const char *varname = RlistScalarValue(args); | ||
| VarRef *ref = ResolveAndQualifyVarName(fp, varname); |
There was a problem hiding this comment.
I believe you will need to VarRefDestroy this.
|
Indeed, this looks quite useful and self contained. If we get docs and acceptance test quickly and the testing goes through, then we can include this, but note that Tuesday next week is a hard deadline for this. No contributions will go in after that. |
tzz
force-pushed
the
feature/redmine7166-data_expand
branch
from
ff25037
to
03c06c9
Compare
|
State-based acceptance test and |
|
trigger build |
Redmine#7166: data_expand() function
|
Passed! Only docs remain. |
|
Docs in cfengine/documentation#1038 |
|
yay! @kacfengine can this be merged now before the freeze? |
|
I has been merged already! :-) |
see https://dev.cfengine.com/issues/7166
Implements
data_expand()as discussed, with example. If this is acceptable I'll write docs and tests.