Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-636 Test that methods can be called by classic arrays #3479

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

nickanderson
Copy link
Member

No description provided.

@cf-bottom
Copy link

Thanks for submitting a pull request! Maybe @olehermanse can review this?

@olehermanse
Copy link
Member

@cf-bottom jenkins

@cf-bottom
Copy link

Alright, I triggered a build:

Build Status

https://ci.cfengine.com/job/pr-pipeline/1883/

#######################################################
#
# Redmine 6369 - make sure that arrays don't accumulate
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redmine??? I know that's an old bug system but why mentioned here? Shouldn't it be CFE-636 mentioned here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craigcomstock @nickanderson Feel free to fix this in a follow-up.

Copy link
Member

@olehermanse olehermanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. A little confusing to me that you submit cherry-pick PR and master PR at the same time, but OK.

@olehermanse olehermanse merged commit 22581a5 into cfengine:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants