Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-3379: Backgrounded commands are now correctly executed in the child process (3.15) #4257

Merged
merged 4 commits into from
Jul 27, 2020
Merged

CFE-3379: Backgrounded commands are now correctly executed in the child process (3.15) #4257

merged 4 commits into from
Jul 27, 2020

Conversation

olehermanse
Copy link
Member

No description provided.

@olehermanse
Backgrounded commands are now correctly executed in the child process
004a3fd 
Changelog: Title
Ticket: CFE-3379
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
(cherry picked from commit 66e0a82)
@olehermanse
Backgrounded child processes no longer run cleanup exit handlers
329d1e0 
I haven't seen this cause issues, but it's more correct.

Changelog: None
Ticket: CFE-3379
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
(cherry picked from commit 7fedde0)
@olehermanse
Cleaned up use of do_work_here variable
30af04e 
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
(cherry picked from commit ea16296)
@olehermanse olehermanse mentioned this pull request Jul 24, 2020
Merged
@olehermanse
Copy link
Member Author

@cf-bottom jenkins, please.

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/5417/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5417/

vpodzime
vpodzime reviewed Jul 24, 2020
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise.

cf-agent/verify_exec.c Outdated Show resolved Hide resolved
@olehermanse
Stopped printing background log message on windows
dfd9a05 
Just a small mistake from previous PR.

Changelog: None
Ticket: CFE-3379
Signed-off-by: Ole Herman Schumacher Elgesem <ole@northern.tech>
(cherry picked from commit c7ee3e9)
@olehermanse olehermanse mentioned this pull request Jul 24, 2020
Merged
@olehermanse olehermanse merged commit f818ee9 into cfengine:3.15.x Jul 27, 2020
@olehermanse olehermanse deleted the 3.15.x_cherry branch July 27, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodzime vpodzime vpodzime left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olehermanse @cf-bottom @vpodzime