Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-10696: Added selinux policy to allow cf-hub to initiate scheduled reports #5334

Merged
merged 1 commit into from
Sep 28, 2023
Merged

ENT-10696: Added selinux policy to allow cf-hub to initiate scheduled reports #5334

merged 1 commit into from
Sep 28, 2023

Conversation

craigcomstock
Copy link
Contributor

https://github.com/cfengine/nova/commit/8b8726e7b2896d601f05d1b4392abef705d1489a
changed cf-hub behavior for ENT-9825

This change fixes an issue with hubs that have SELinux set to enforce.
Hubs which do not have SELinux set to enforce are unaffected by this issue.

Ticket: ENT-10696
Changelog: title

@craigcomstock
Added selinux policy to allow cf-hub to initiate scheduled reports
48ed76f 
cfengine/nova@8b8726e
changed cf-hub behavior for ENT-9825

This change fixes an issue with hubs that have SELinux set to enforce.
Hubs which do not have SELinux set to enforce are unaffected by this issue.

Ticket: ENT-10696
Changelog: title
@craigcomstock
Copy link
Contributor Author

checked the policy can compile and install on a rhel-8 machine, so @cf-bottom lets do jenkins

sudo yum install selinux-policy-devel
make -f /usr/share/selinux/devel/Makefile  -j1
semodule -i cfengine-enterprise.pp

@cf-bottom
Copy link

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/9895/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9895/

@craigcomstock
Copy link
Contributor Author

win-acceptance failure seems like a flake: logged a ticket to improve: https://northerntech.atlassian.net/browse/ENT-10699

@craigcomstock
Copy link
Contributor Author

sequential-tests failure seems related to changes in postinstall scriptlets around postgresql start/stop during upgrade. In upgrade from 3.18.5 to master it seems failures occurred in the logs but maybe not actual failures, so will check and see how nightlies go and re-run this if they are OK or fix/revert cfengine/buildscripts#1295

@craigcomstock
Copy link
Contributor Author

out of curiosity, I reran the sequential-test job: Build Status

vpodzime
vpodzime approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. This should eventually be moved to cf-reactor. Hopefully soon...

@craigcomstock craigcomstock merged commit e3f612e into cfengine:master Sep 28, 2023
44 of 46 checks passed
@craigcomstock craigcomstock deleted the ENT-10696/master branch September 28, 2023 19:47
@craigcomstock
Copy link
Contributor Author

cherry picks
#5336
#5335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodzime vpodzime vpodzime approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@craigcomstock @cf-bottom @vpodzime