Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-6117/master: Added replace_uncommented_substrings #1811

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

nickanderson
Copy link
Member

This bundle and accompanying body aid in replacing all occurrences of a string
in a file that do not follow a comment character.

Ticket: ENT-6117
Changelog: Title

@nickanderson nickanderson added the WIP Work in Progress label Aug 6, 2020
@nickanderson nickanderson force-pushed the ENT-6117/master branch 3 times, most recently from 6c30d92 to 1a0fa7f Compare August 6, 2020 20:13
@nickanderson nickanderson removed the WIP Work in Progress label Aug 6, 2020
@cf-bottom
Copy link

Thanks for submitting a pull request! Maybe @craigcomstock can review this?

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@cf-bottom
Copy link

@nickanderson
Copy link
Member Author

Feel free to bikeshed the naming of variables/bundles/bodies.

Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just please make sure to squash the commits.

@nickanderson
Copy link
Member Author

Squashed.

@nickanderson
Copy link
Member Author

@cf-bottom jenkins, please

@cf-bottom
Copy link

Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. a few comments.

lib/files.cf Outdated Show resolved Hide resolved
This bundle and accompanying body aid in replacing all occurrences of a string
in a file that do not follow a comment character.

Ticket: ENT-6117
Changelog: Title
@nickanderson nickanderson merged commit 6caf8c2 into cfengine:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants