-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENT-6117/master: Added replace_uncommented_substrings #1811
Conversation
6c30d92
to
1a0fa7f
Compare
Thanks for submitting a pull request! Maybe @craigcomstock can review this? |
@cf-bottom jenkins, please |
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/5472/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5472/ |
Feel free to bikeshed the naming of variables/bundles/bodies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just please make sure to squash the commits.
1a0fa7f
to
abbb4c8
Compare
Squashed. |
@cf-bottom jenkins, please |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/5473/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-5473/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool. a few comments.
This bundle and accompanying body aid in replacing all occurrences of a string in a file that do not follow a comment character. Ticket: ENT-6117 Changelog: Title
e079953
to
d77f5de
Compare
This bundle and accompanying body aid in replacing all occurrences of a string
in a file that do not follow a comment character.
Ticket: ENT-6117
Changelog: Title