Change: Inform guards to DEBUG #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inform mode is supposed to inform you of changes to the system, debug is more appropriate for these informational messages. Also not using the same class as defined by the log level options to the agent allows us to not be overwhelemed with output when doing policy debugging. Ref: https://dev.cfengine.com/issues/7318
| "$(this.bundle): editing of the sudoers file is disabled; the Apache user may not be able to run passwordless sudo cf-runagent"; | ||
| (DEBUG|DEBUG_cfengine_internal_apache_sudoer).!cfengine_internal_sudoers_editing_enable:: | ||
| "DEBUG $(this.bundle): Editing of the sudoers file is disabled. The Apache user | ||
| may not be able to run passwordless sudo cf-runagent"; |
There was a problem hiding this comment.
The class expression at the top is now obsolete. Remove?
|
Yes, removed. |
|
trigger build |
|
Cherry-picked to 3.7.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inform mode is supposed to inform you of changes to the system, debug is more
appropriate for these informational messages. Also not using the same class as
defined by the log level options to the agent allows us to not be overwhelemed
with output when doing policy debugging.
Ref: https://dev.cfengine.com/issues/7318