Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added testing for presence of a CITATION.cff #22

Merged
merged 5 commits into from
Jan 31, 2022
Merged

Added testing for presence of a CITATION.cff #22

merged 5 commits into from
Jan 31, 2022

Conversation

jspaaks
Copy link
Contributor

@jspaaks jspaaks commented Jan 31, 2022

Description

In this branch we're working on adding a filter that uses the GitHub API to check that a file named "CITATION.cff" is present in the root of the repo.

Related issues:

Instructions to review the pull request

  • Make a GitHub Access token here https://github.com/settings/tokens
  • cp secrets.txt.example secrets.txt
  • Update the value of GITHUB_TOKEN in secrets.txt
  • install Node >= 14
  • cd $(mktemp -d --tmpdir cffbot-XXXXXX)
    git clone https://github.com/cffbots/filtering .
    git checkout <this-branch>
    source secrets.txt
    node query.mjs
    

@jspaaks jspaaks marked this pull request as ready for review January 31, 2022 15:26
@jspaaks jspaaks changed the title partial commit: testing for presence of a CITATION.cff, issue #2 Added testing for presence of a CITATION.cff Jan 31, 2022
Copy link
Contributor

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I have two suggestions:

  • Change instructions to have a GITHUB_TOKEN so we can bypass the secrets.txt file.
  • octokit was not available (because there is no package.json?), so maybe we need package.json before.

Copy link
Contributor

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. 🧇

@jspaaks
Copy link
Contributor Author

jspaaks commented Jan 31, 2022

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants