don't silently ignore invalid lines in .reapack-index.conf

cfillion · Sep 17, 2017 · 4661f1b · 4661f1b
1 parent 162b904
commit 4661f1b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/reapack/index/cli/options.rb b/lib/reapack/index/cli/options.rb
@@ -36,6 +36,7 @@ def read_config
 
       opts = Shellwords.split File.read(path)
       @opts = parse_options(opts, dir).merge @opts
+      raise ArgumentError, "invalid option: #{opts.first}" unless opts.empty?
     }
   rescue ArgumentError => e
     raise ReaPack::Index::Error, e.message

diff --git a/test/test_cli.rb b/test/test_cli.rb
@@ -170,6 +170,16 @@ def test_config_line_break
     end
   end
 
+  def test_config_garbage
+    assert_output '', /invalid option: not$/ do
+      catch :stop do
+        wrapper [], setup: proc {
+          mkfile '.reapack-index.conf', "not an option"
+        }
+      end
+    end
+  end
+
   def test_working_directory_with_options
     wrapper do
       @git.create_commit 'initial commit',