Update date range advisory text to display no matter what range is se…

…lected (#477) * Removes conditional and variables so that text is displayed all the time; adds top margin class * Update DateFilter test snapshot --------- Co-authored-by: Bill Whorton <> Co-authored-by: Chris Contolini <contolini@users.noreply.github.com>
cfpb · Nov 6, 2023 · 06888a7 · 06888a7
1 parent 6099278
commit 06888a7
Show file tree

Hide file tree

Showing 5 changed files with 52 additions and 26 deletions.
diff --git a/dist/ccdb5.js b/dist/ccdb5.js
diff --git a/dist/ccdb5.js.map b/dist/ccdb5.js.map
diff --git a/src/actions/filter.js b/src/actions/filter.js
@@ -1,7 +1,7 @@
 import { REQUERY_ALWAYS } from '../constants';
 
-export const DATE_INTERVAL_CHANGED = 'DATE_INTERVAL_CHANGED';
-export const DATE_RANGE_CHANGED = 'DATE_RANGE_CHANGED';
+export const DATE_INTERVAL_CHANGED = 'changeDateInterval';
+export const DATE_RANGE_CHANGED = 'changeDateRange';
 export const DATES_CHANGED = 'DATES_CHANGED';
 export const FILTER_ALL_REMOVED = 'FILTER_ALL_REMOVED';
 export const FILTER_CHANGED = 'FILTER_CHANGED';

diff --git a/src/components/Filters/DateFilter.js b/src/components/Filters/DateFilter.js
@@ -40,10 +40,6 @@ export const DateFilter = () => {
   const [throughDate, setThroughDate] = useState(initialThroughDate);
   const dispatch = useDispatch();
 
-  const from = fromDate || minDate;
-  const through = throughDate || maxDate;
-
-  const showWarning = dayjs('2017-04-23').isBetween(from, through, 'day');
   const errorMessageText = "'From' date must be less than 'through' date";
 
   const fromRef = useRef();
@@ -211,22 +207,20 @@ export const DateFilter = () => {
             </span>
           </>
         ) : null}
-        {showWarning ? (
-          <p>
-            {' '}
-            {WARN_SERIES_BREAK}
-            <a
-              href={LEARN_SERIES_BREAK}
-              target="_blank"
-              rel="noopener noreferrer"
-              aria-label="Learn more about Product and
+        <p className="u-mt15">
+          {' '}
+          {WARN_SERIES_BREAK}
+          <a
+            href={LEARN_SERIES_BREAK}
+            target="_blank"
+            rel="noopener noreferrer"
+            aria-label="Learn more about Product and
                   Issue changes (opens in new window)"
-            >
-              {' '}
-              Learn More
-            </a>
-          </p>
-        ) : null}
+          >
+            {' '}
+            Learn More
+          </a>
+        </p>
       </div>
     </CollapsibleFilter>
   );

diff --git a/src/components/Filters/__tests__/__snapshots__/DateFilter.spec.js.snap b/src/components/Filters/__tests__/__snapshots__/DateFilter.spec.js.snap
@@ -151,7 +151,9 @@ exports[`component::DateFilter snapshot shows a warning for April 2017 1`] = `
           All
         </button>
       </section>
-      <p>
+      <p
+        className="u-mt15"
+      >
          
         CFPB updated product and issue options in April 2017 and August 2023
         <a
@@ -330,6 +332,21 @@ exports[`component::DateFilter snapshot shows errors 1`] = `
           error-round.svg
         </svg>
       </span>
+      <p
+        className="u-mt15"
+      >
+         
+        CFPB updated product and issue options in April 2017 and August 2023
+        <a
+          aria-label="Learn more about Product and Issue changes (opens in new window)"
+          href="https://www.consumerfinance.gov/data-research/consumer-complaints/#past-changes"
+          rel="noopener noreferrer"
+          target="_blank"
+        >
+           
+          Learn More
+        </a>
+      </p>
     </div>
   </div>
 </section>
@@ -486,6 +503,21 @@ exports[`component::DateFilter snapshot supports no dates in the Redux Store 1`]
           All
         </button>
       </section>
+      <p
+        className="u-mt15"
+      >
+         
+        CFPB updated product and issue options in April 2017 and August 2023
+        <a
+          aria-label="Learn more about Product and Issue changes (opens in new window)"
+          href="https://www.consumerfinance.gov/data-research/consumer-complaints/#past-changes"
+          rel="noopener noreferrer"
+          target="_blank"
+        >
+           
+          Learn More
+        </a>
+      </p>
     </div>
   </div>
 </section>