Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update date range advisory text to display no matter what range is selected #477

Merged
merged 2 commits into from Nov 6, 2023

Conversation

wwhorton
Copy link
Contributor

Removes conditional and variables so that text is displayed all the time; adds top margin class to give some space between the text and the date range buttons.

Changes

  • Removes conditional from DateFilter.js and adds u-mt15 class

Testing

  • yarn test should pass
  • Visit CCDB and click date range buttons; text should always be visible

Screenshots

Screenshot 2023-10-26 at 3 31 09 PM

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@contolini
Copy link
Member

@wwhorton Code looks good and works as expected 🎉 Locally, I'm seeing a test failure I think because this snapshot line needs the new className="u-mt15" added to it.

@contolini contolini force-pushed the WW-DATAP-1225-date-range-text branch from 2578315 to 103bb62 Compare November 6, 2023 19:02
@contolini contolini added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 06888a7 Nov 6, 2023
2 checks passed
@contolini contolini deleted the WW-DATAP-1225-date-range-text branch November 6, 2023 19:10
@contolini
Copy link
Member

Merging this so I can cut a release and deploy to demo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants