Feedback properties #299
Merged
Feedback properties #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also makes some minor fixes: - A bug in the `update_colleges` script that caused grad_rates to fail to update - Some documentation updates
9 tasks
willbarton
approved these changes
Apr 25, 2017
paying_for_college/models.py
Outdated
| if row and row.get('iped'): | ||
| return School.objects.get(pk=row['iped']) | ||
| else: | ||
| return '' |
There was a problem hiding this comment.
Is a '' return here (and line 758) appropriate in place of a School? I don't see right off where this is called, so I'm not sure.
paying_for_college/models.py
Outdated
| def total_fields(field_list): | ||
| total = 0 | ||
| for field in field_list: | ||
| if field in url_data.keys() and url_data[field] != '': |
There was a problem hiding this comment.
if url_data.get('field', '') != '' might be simpler here.
|
@willbarton Thanks for the close review. suggestions taken! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Feedback model properties to assist in analysis
This addresses GHE paying-for-college/dynamic-disclosures-dev issue 226
The PR also makes some minor script fixes that address #298:
update_collegesscript that caused grad_rates to fail to updateAdditions