-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback properties #299
Feedback properties #299
Conversation
This PR also makes some minor fixes: - A bug in the `update_colleges` script that caused grad_rates to fail to update - Some documentation updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. Nice style cleanup. Lack of familiarity with the code means I'm going over this with a fine-toothed nit picker, but neither of my comments are blockers.
paying_for_college/models.py
Outdated
if row and row.get('iped'): | ||
return School.objects.get(pk=row['iped']) | ||
else: | ||
return '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a ''
return here (and line 758) appropriate in place of a School
? I don't see right off where this is called, so I'm not sure.
paying_for_college/models.py
Outdated
def total_fields(field_list): | ||
total = 0 | ||
for field in field_list: | ||
if field in url_data.keys() and url_data[field] != '': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if url_data.get('field', '') != ''
might be simpler here.
@willbarton Thanks for the close review. suggestions taken! |
Add Feedback model properties to assist in analysis
This addresses GHE paying-for-college/dynamic-disclosures-dev issue 226
The PR also makes some minor script fixes that address #298:
update_colleges
script that caused grad_rates to fail to updateAdditions