Add missing key-terms
slug to DefinedTerm URL tag
#6000
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our contacts at Google alerted us to an oversight of mine when I implemented our DefinedTerm markup: the URL for each term that goes in the
<link itemprop="url" href="{URL}">
tag was missing thekey-terms/
part of the URL. Turns out, our use of RoutablePageMixin to generate the Key Terms pages meant that thepage.full_url
tag was not including thatkey-terms/
part of the URL.I tried using theroutablepageurl
template tag, but that only returns a root-relative URL, whereas we need an absolute URL, and it required hardcoding acategory='key-terms'
kwarg, anyway, so we might as well just hardcode it this way./cc @kelleyholden
How to test this PR
<link itemprop="url" …>
tag'shref
attribute does not include thekey-terms/
path segmentkey-terms/
is now includedChecklist