Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paying for College - Bug Fixes #6090

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Paying for College - Bug Fixes #6090

merged 2 commits into from
Oct 29, 2020

Conversation

mistergone
Copy link
Member

  • Fix bug which breaks URL querystring updates
  • Fix content issue
  • Remove monthly loan payment from "Average Monthly Spending" on budget page

How to test this PR

  1. Pull it down and get it running!
  2. Navigate to http://0.0.0.0:8000/paying-for-college/your-financial-path-to-graduation/

And you may ask yourself:

  • Does going through the app update the URL querystring?
  • Does the budget page no longer include
  • Is the "Action Plan" content updated properly? (See team issue 276)
  • Well... how did I get here?

Checklist

  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".
  • Changes are limited to a single goal (no scope creep)
  • Code follows the standards laid out in the CFPB development guidelines

- Fix bug which breaks URL querystring updates
- Fix content issue
- Remove monthly loan payment from "Average Monthly Spending" on budget page
@mistergone mistergone self-assigned this Oct 28, 2020
@virginiacc virginiacc merged commit 24e4660 into main Oct 29, 2020
@virginiacc virginiacc deleted the pfc-bug-fix branch October 29, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants