TDP: semi-terrible fix for activities search bug #7659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TDP has an existing bug in production
This PR performs a semi-terrible solution of copying the older expandable JS code into TDP, in order to fix the bug, while isolating it from the current design-system expandable code.
Additions
Changes
is_collapsed_for_mobile
from standard expandable, which was added in TDP Activity Search: Mobile customization #6427 in service of TDP custom expandables.How to test this PR
yarn build
and check http://localhost:8000/consumer-tools/educator-tools/youth-financial-education/teach/activities/?q= vs production and see that when the expandable facets are toggled they don't overlap themselves.Notes and todos